Structural Mechanics Calculation for Strain#49
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Vybornak2
left a comment
There was a problem hiding this comment.
in stress version stress_vector_voigt is used while in strain strain_voigt. This should be unified. I suggest vector version.
test for test_calc_signed_von_mises_by_max_abs_principal utilize second invariant of deviatoric stress as tests for stress version do, but I am not sure about this formula for strain variants. Please check this (potentially mistake could be in stress version too)
KarasTomas
left a comment
There was a problem hiding this comment.
Added the requested changes. There are still few comments that need discussion.
src/fatpy/struct_mech/strain.py
Outdated
|
|
||
|
|
||
| # Von Mises functions | ||
| def calc_von_mises_strain_from_principals( |
There was a problem hiding this comment.
Moved to a branch sm_strain_dev in my fork. The test as well.
|
@KarasTomas
Addressing issues - Quote:
|
|
@KarasTomas review is required as I pushed last change - merge, please review it (just a formality), so we can close this PR. |
KarasTomas
left a comment
There was a problem hiding this comment.
PR is ready for merge.
Implementation of strain funkcionality based on the Issue #33.
There are still some topics that needs to be discussed: